merge: from main to 3.0 branch #34204
Conversation
Closes: 6659972418
…ctoring count functions (#34176) * fix: enhance memory leak detection by adding ignore patterns and refactoring count functions * fix: refactor memory leak detection logic and consolidate ignore patterns * chore: remove redundent spaces Signed-off-by: WANG Xu <feici02@outlook.com> --------- Signed-off-by: WANG Xu <feici02@outlook.com> Co-authored-by: WANG Xu <feici02@outlook.com>
guanshengliang
requested review from
a team,
dapan1121,
feici02,
hzcheng and
zitsen
as code owners
Summary of ChangesHello @guanshengliang, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request integrates recent developments from the main branch into the 3.0 branch, bringing a suite of improvements across core functionality, documentation, and testing. Key changes include the introduction of SLIMIT for GROUP BY queries to enhance data retrieval control, a major update to the documentation covering new SQL keywords and connector compatibility, and a forward-looking 2026 product roadmap. Furthermore, the testing framework has been substantially upgraded to support concurrent data ingestion and more robust stream processing verification, ensuring higher quality and efficiency in development cycles. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily focuses on documentation updates and minor code improvements. Documentation changes include standardizing SQL examples to use uppercase keywords and semicolons, correcting a typo in an anomaly detection function name, and refining descriptions for backup plans and disaster recovery. The release history and product roadmap documents have been significantly updated, moving release information to a new central location and updating the roadmap from 2025 to 2026 with new quarterly features. Compatibility guarantees for WebSocket connections have been added to connector documentation in both English and Chinese, specifying minimum version requirements for various language connectors. The SQL keyword lists in both English and Chinese documentation have been expanded to include numerous new keywords introduced in version 3.4.0.0+ and 3.3.6.3+, with a review comment highlighting and requesting the removal of several duplicated keywords in the English list. Code changes involve adding a comment to a SLimit struct, improving error handling in dataInserter.c, and enhancing groupoperator.c to support SLimit functionality for grouped aggregation results, including new functions for slimit processing and initialization. Additionally, the generate_totp_secret function is marked as deprecated in builtins.c, and a related comment in sql.y is updated. Test files (test_write_insert_select.py, test_slimit.py) have been updated to include new test cases for INSERT...SELECT and SLIMIT with GROUP BY aggregations, along with general improvements to ASAN memory leak checking, coverage exclusion, and TSBS test harness scripts for stream processing scenarios, including changes to stream_options from fill_history_first to IGNORE_DISORDER, updated interval and sliding values, and adjusted written_concurrent settings in data configuration files.
| | RIGHT | | | ||
| | ROLLUP | | | ||
| | ROW | | | ||
| | ROWTS | | | ||
| | RP | | | ||
| | RSHIFT | | |
There was a problem hiding this comment.
There are several duplicated keywords in this list (RIGHT, ROLLUP, ROW, ROWTS, RP, RSHIFT). Please remove these duplicate entries to keep the list clean and accurate.
Description
Issue(s)
Checklist
Please check the items in the checklist if applicable.